Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): remove remaining spectrum references #26389

Merged

Conversation

taylorcjohnson
Copy link
Contributor

Description

This PR attempts to remove remaining references to the Gatsby Spectrum community in documentation. Currently, it is separated into two commits:
Removing Spectrum from contributing and README files
Removing Spectrum from #100DaysOfGatsby blog series

I have two outstanding questions:
Is it appropriate for this PR to remove the Spectrum reference from already published blog posts (i.e., the second commit)?

If so, there are two additional blogs posts (not yet included in the PR) where Chris Biscardi introduces Gatsby themes and specifically discusses the gatsby-themes channel in Spectrum (not simply linking out to them) - could someone suggest how (or if) I should modify these? Thank you in advance!

  1. https://github.com/gatsbyjs/gatsby/blob/9ec02711eb21b4b446c5792a99618e67959e439b/docs/blog/2018-11-11-introducing-gatsby-themes/index.md
  2. https://github.com/gatsbyjs/gatsby/blob/bc82867cec6076fa83adef4de319e8e6d03beb75/docs/blog/2019-02-27-reactiflux-q-and-a/index.md

Documentation

Not applicable - this PR does not change/add any code that would require documentation

Related Issues

Fixes #26351

@taylorcjohnson taylorcjohnson requested review from a team as code owners August 12, 2020 06:11
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 12, 2020
@bitmaks bitmaks added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 12, 2020
@AishaBlake
Copy link

Hey, @taylorcjohnson! Thanks for following up on this! I generally prefer not to mess with blog posts once they've been published but I'll tag @mgienow in here for the final word. Once she's made a call, one way or the other, I'll be happy to review this.

@taylorcjohnson
Copy link
Contributor Author

Sounds great @AishaBlake - that completely makes sense. Looks like the build failed due to dependency issues anyway (not sure why exactly), so I may wait until the final verdict and start over with a fresh fork 🤷?

Apologies for the triple reviewer request! Didn't realize GitHub would automatically add those maintainer groups with you already in them! 🤦

@muescha
Copy link
Contributor

muescha commented Aug 12, 2020

personally i would expect that blogpost get updated with with small bug fixes or generic information changes like the spectrum link.

@AishaBlake
Copy link

personally i would expect that blogpost get updated with with small bug fixes or generic information changes like the spectrum link.

In this specific case, yes, I'd agree. Regardless, I'd like to run this by Michelle. @taylorcjohnson, I appreciate you breaking this up into the two commits. Either way, this should be a smooth change!

@AishaBlake AishaBlake added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Aug 18, 2020
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @mgienow and while doing that realized that the blog posts are stored in WordPress now anyways (the live ones), so changing the markdown files here only helps when people browse the repository on their own.

I'll file an internal ticket to update the posts in WordPress. I also replaced Spectrum with our AskGatsbyJS twitter account in both READMEs

@LekoArts LekoArts merged commit 105d74f into gatsbyjs:master Sep 17, 2020
@taylorcjohnson taylorcjohnson deleted the docs/remove-spectrum-references branch September 17, 2020 18:05
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Co-authored-by: Lennart <lekoarts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response type: documentation An issue or pull request for improving or updating Gatsby's documentation
5 participants