Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-documentationjs) Add many: true to @childOf declaration in DocumentationJS #25394

Merged
merged 3 commits into from
Jun 30, 2020
Merged

fix(gatsby-transformer-documentationjs) Add many: true to @childOf declaration in DocumentationJS #25394

merged 3 commits into from
Jun 30, 2020

Conversation

tesseralis
Copy link
Contributor

@tesseralis tesseralis commented Jun 29, 2020 •
edited
Loading

Description

Followup of #25113. Fix the @childOf declaration in the DocumentationJs type so that the parent types properly get childrenDocumentationJs instead of childDocumentationJs.
@tesseralis tesseralis requested a review from a team as a code owner June 29, 2020 19:47
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 29, 2020
@tesseralis tesseralis requested a review from vladar June 29, 2020 19:48
@tesseralis tesseralis requested a review from LekoArts June 29, 2020 20:20
@LekoArts LekoArts added topic: website and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 30, 2020
LekoArts
LekoArts approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@LekoArts LekoArts merged commit 2b34e7e into master Jun 30, 2020
@LekoArts LekoArts deleted the transformer-documentationjs/fix-childof-many branch June 30, 2020 05:47
@tesseralis tesseralis mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@tesseralis @LekoArts