Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(www): Use createSchemaCustomization instead of sourceNodes #25277

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

tesseralis
Copy link
Contributor

Description

Define new node types in createSchemaCustomization instead of in sourceNodes.

Motivation

Makes more sense — schema type creation is part of schema customization, not node sourcing. I don't know why createTypes is available in sourceNodes.

@tesseralis tesseralis requested a review from a team as a code owner June 25, 2020 02:55
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 25, 2020
@LekoArts LekoArts added topic: website and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 25, 2020
@tesseralis tesseralis merged commit 7b1ec01 into master Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the source-nodes branch June 29, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants