Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Add better messaging on how to add new words to the dictionary for spell-check #25275

Merged
merged 6 commits into from
Jul 6, 2020

Conversation

tesseralis
Copy link
Contributor

@tesseralis tesseralis commented Jun 25, 2020

Description

  • Add a yarn update-dictionary script to call scripts/update-dictionary.js for updating the dictionary with new words.
  • Add a message at the end of yarn lint:docs with instructions for adding words:
Found linting errors in the docs. To add new words to the dictionary, run `yarn update-dictionary`.

Related Issues

Fixes: #25268

@tesseralis tesseralis requested a review from a team as a code owner June 25, 2020 00:03
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 25, 2020
@marcysutton
Copy link
Contributor

Thanks for adding this! It would be awesome to also add something to the contributing docs about running the script. Perhaps on the Docs Contributions page? Does the scope of the bot include any other content? https://www.gatsbyjs.org/contributing/docs-contributions/

@tesseralis
Copy link
Contributor Author

@marcysutton the linter has a couple of grammar rules in addition to spell-checking. I think the best place to put it might be the [Gatsby Style Guide]? Add a foreword at the beginning like "we use remark to check formatting and retext to check several of the rules in this guide. [more info on how to run the linter and fix things]".

@pvdz pvdz added status: needs docs review Pull request related to documentation waiting for review type: dx type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer status: needs docs review Pull request related to documentation waiting for review labels Jun 30, 2020
@muescha
Copy link
Contributor

muescha commented Jun 30, 2020

some words are should not go into the dictionary - they should be in code fences
this should also mentioned in the docs

@marcysutton
Copy link
Contributor

Style Guide would work, and I agree adding a note about code fences would be necessary too.

@tesseralis tesseralis requested a review from a team as a code owner July 2, 2020 01:22
83:34-83:40 warning `retext` is misspelt; did you mean `pretext`, `retest`? retext retext-spell
```

You can add these words to the dictionary with the following command:
Copy link
Contributor

@muescha muescha Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here i would add a hint to check at first the code fences.

something like this (but it needs better wording):

At first check if these words are are variables, component names, 
function names, and packages, then you can put them in 
code fences (see section [Code formatting: Inline code](...)). 
Otherwise you can add the remaining words to the dictionary with the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also to check the brand names before checking, otherwise wrong spelled brand names get into the dictionary...

Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
@gatsby-cloud-staging
Copy link

Your pull request can be previewed in Gatsby Cloud: https://build-76c0f1ce-06a5-4f79-87ae-666029736d8a.staging-previews.gtsb.io

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, Nat! This is good as far as I'm concerned.

@AishaBlake AishaBlake merged commit c05e445 into master Jul 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the dictionary branch July 6, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
5 participants