-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Add better messaging on how to add new words to the dictionary for spell-check #25275
Conversation
Thanks for adding this! It would be awesome to also add something to the contributing docs about running the script. Perhaps on the Docs Contributions page? Does the scope of the bot include any other content? https://www.gatsbyjs.org/contributing/docs-contributions/ |
@marcysutton the linter has a couple of grammar rules in addition to spell-checking. I think the best place to put it might be the [Gatsby Style Guide]? Add a foreword at the beginning like "we use remark to check formatting and retext to check several of the rules in this guide. [more info on how to run the linter and fix things]". |
some words are should not go into the dictionary - they should be in code fences |
Style Guide would work, and I agree adding a note about code fences would be necessary too. |
83:34-83:40 warning `retext` is misspelt; did you mean `pretext`, `retest`? retext retext-spell | ||
``` | ||
|
||
You can add these words to the dictionary with the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here i would add a hint to check at first the code fences.
something like this (but it needs better wording):
At first check if these words are are variables, component names,
function names, and packages, then you can put them in
code fences (see section [Code formatting: Inline code](...)).
Otherwise you can add the remaining words to the dictionary with the following command:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also to check the brand names before checking, otherwise wrong spelled brand names get into the dictionary...
Co-authored-by: Aisha Blake <aisha@gatsbyjs.com>
Your pull request can be previewed in Gatsby Cloud: https://build-76c0f1ce-06a5-4f79-87ae-666029736d8a.staging-previews.gtsb.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes, Nat! This is good as far as I'm concerned.
Description
yarn update-dictionary
script to callscripts/update-dictionary.js
for updating the dictionary with new words.yarn lint:docs
with instructions for adding words:Related Issues
Fixes: #25268