Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): 🔒 Fix missing HTTPS on github.io links #24918

Merged
merged 1 commit into from
Jun 11, 2020
Merged

chore(docs): 🔒 Fix missing HTTPS on github.io links #24918

merged 1 commit into from
Jun 11, 2020

Conversation

jbampton
Copy link
Contributor

Description

By default github.io subdomains are served over HTTPS
@jbampton jbampton requested review from a team as code owners June 11, 2020 07:37
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 11, 2020
gillkyle
gillkyle approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't commonly update blog posts retroactively but because this doesn't change the content or even what's rendered I don't see why that would be a problem here.

Thanks for the changes! 👍
@gillkyle gillkyle merged commit 17ca485 into gatsbyjs:master Jun 11, 2020
@jbampton jbampton deleted the fix-github-io-links branch June 11, 2020 18:50
axe312ger pushed a commit that referenced this pull request Jun 23, 2020
@jbampton @axe312ger
chore(docs): 🔒 Fix missing HTTPS on github.io links (#24918)
65676df
@pvdz pvdz added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
3 participants
@jbampton @gillkyle @pvdz