Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(style guide): new section about internal links #21871

Merged

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Mar 1, 2020

Description

changes:

  • new section about internal links
  • fix internal links in example code
  • add example for localhost links

PS: i ask for help with wording, because i am not native english speaker

@muescha muescha requested a review from a team as a code owner March 1, 2020 00:40
@freiksenet freiksenet added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Mar 2, 2020
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition! Thanks @muescha. Made some recommendations below.

docs/contributing/gatsby-style-guide.md Outdated Show resolved Hide resolved

<!-- Bad -->

[here](https://www.gatsbyjs.org/docs/ "Gatsby's docs")
[here](/docs/ "Gatsby's docs")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note as above, let's keep these as is for now.

docs/contributing/gatsby-style-guide.md Outdated Show resolved Hide resolved
docs/contributing/gatsby-style-guide.md Outdated Show resolved Hide resolved
muescha and others added 3 commits March 4, 2020 05:10
Co-Authored-By: LB <laurie@gatsbyjs.com>
Co-Authored-By: LB <laurie@gatsbyjs.com>
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@laurieontech laurieontech merged commit 1a09edb into gatsbyjs:master Mar 6, 2020
@muescha muescha deleted the muescha/fix/docs-codestyles-links branch March 6, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
3 participants