Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize date objects in markdown frontmatter to avoid type mismatches when inferring GraphQL types #2163

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Serialize date objects in markdown frontmatter to avoid type mismatches when inferring GraphQL types #2163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bc6c3e
Serialize date objects in markdown frontmatter to avoid type mismatch…
KyleAMathews Sep 18, 2017
83d7ab6
Fix test
KyleAMathews Sep 18, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test
  • Loading branch information
@KyleAMathews
KyleAMathews committed Sep 18, 2017
commit 83d7ab6144a40e66fa50aeb41bcf902d726d66d3
8 changes: 4 additions & 4 deletions packages/gatsby-transformer-remark/src/__tests__/__snapshots__/gatsby-node.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,20 @@ Array [
"child": Object {
"children": Array [],
"frontmatter": Object {
"date": "12/12/2014",
"date": "2017-09-18T23:19:51.246Z",
"parent": "whatever",
"title": "my little pony",
},
"id": "whatever >>> MarkdownRemark",
"internal": Object {
"content": "---
title: \\"my little pony\\"
date: \\"12/12/2014\\"
date: \\"2017-09-18T23:19:51.246Z\\"
---

Where oh where is my little pony?
",
"contentDigest": "54cfa2ad99756f2fa232cac585280a37",
"contentDigest": "1235e2d6fdcadd5f09bf4c221bdf9094",
"type": "MarkdownRemark",
},
"parent": "whatever",
Expand All @@ -57,7 +57,7 @@ Where oh where is my little pony?
"children": Array [],
"content": "---
title: \\"my little pony\\"
date: \\"12/12/2014\\"
date: \\"2017-09-18T23:19:51.246Z\\"
---

Where oh where is my little pony?
Expand Down
4 changes: 3 additions & 1 deletion packages/gatsby-transformer-remark/src/__tests__/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ Where oh where is my little pony?
boundActionCreators,
}).then(() => {
expect(createNode.mock.calls).toMatchSnapshot()
expect(_.isString(createNode.mock.calls[0].frontmatter.date)).toBeTruthy()
expect(
_.isString(createNode.mock.calls[0][0].frontmatter.date)
).toBeTruthy()
expect(createParentChildLink.mock.calls).toMatchSnapshot()
expect(createNode).toHaveBeenCalledTimes(1)
expect(createParentChildLink).toHaveBeenCalledTimes(1)
Expand Down