Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(www): Remove blank component #19970

Merged
merged 2 commits into from
Dec 6, 2019
Merged

chore(www): Remove blank component #19970

merged 2 commits into from
Dec 6, 2019

Conversation

m-allanson
Copy link
Contributor

Description

This component didn't seem to be doing anything. However, it was triggering an error in the browser console:

Warning: Failed prop type: The prop `children` is marked as required in `HomepageSection`, but its value is `undefined`.

For reference, here is where HomepageSection is defined: https://github.com/gatsbyjs/gatsby/blob/master/www/src/components/homepage/homepage-section.js

Documentation

n/a

Related Issues

n/a
@m-allanson m-allanson requested a review from a team as a code owner December 6, 2019 12:32
laurieontech
laurieontech approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks @m-allanson.
@laurieontech laurieontech merged commit 6d68af8 into master Dec 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the www-empty-component branch December 6, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@m-allanson @laurieontech