Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure all docjs elements are typed #19510

Merged
merged 2 commits into from
Nov 14, 2019
Merged

fix: ensure all docjs elements are typed #19510

merged 2 commits into from
Nov 14, 2019

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Nov 14, 2019

Description

Rounds out the type declaration for docjs for fields that were missed.

Related Issues
@jquense jquense requested a review from a team as a code owner November 14, 2019 14:36
pieh
pieh approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for update!
@pieh pieh merged commit ab8adbc into master Nov 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-docjs-types branch November 14, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jquense @pieh