fix(gatsby-transformer-sharp): explicitly register enum types #19343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muescha
reviewed
Nov 8, 2019
| DuotoneGradientType, | ||
| PotraceTurnPolicyType, | ||
| PotraceType, | ||
| imageSharpType, |
There was a problem hiding this comment.
just my nitpick - should it not be like other Types capitalized?
Suggested change
| imageSharpType, | |
| ImageSharpType, |
also should changed in this line:
- const imageSharpType = schema.buildObjectType({
+ const ImageSharpType = schema.buildObjectType({
There was a problem hiding this comment.
This is not strictly part of this PR, so IMO - let's merge this PR and we can do style commit (if anyone feel very strongly about it) separately?
|
Thank you @stefanprobst 🎉 Let's merge and update later if necessary. |
rickiesmooth
pushed a commit
to rickiesmooth/gatsby
that referenced
this pull request
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly register transformer-sharp enums -- this is needed for schema snapshoting to work correctly
related: #19210