fix(starters): revert Kentico Kontent starter #19213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting this as it's causing a build error for .org. See https://circleci.com/gh/gatsbyjs/gatsby/266617
laurieontech
added
the
bot: merge on green
|
Hey @m-allanson, yes the source folder is required from our web-template manager: But this approach is changeable - it is an ongoing process to define the best practices for the starters, so I will change the guidelines and make the source folder optional. |
|
@m-allanson everything should be fixed - should I make another pull request, or you are gonna mage a revert of the revert 😄 ? |
rickiesmooth
pushed a commit
to rickiesmooth/gatsby
that referenced
this pull request
Nov 8, 2019
Reverting this as it's causing a build error for .org. See https://circleci.com/gh/gatsbyjs/gatsby/266617
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey @Simply007! Thanks for adding the starter in #19187. Unfortunately this starter is breaking the .org site build as it expects the project to have a
package.jsonfile in the project root (see the build log here).As the Gatsby files are in the
sourcesubdirectory it means the instructions fromgatsby newwill also fail.I'm going to remove the starter in this PR, but would like to work out how we can re-add it :)
What do you think about moving the Gatsby files to the root of the repo? From the commit messages it sounds like that might clash with some other guidelines?
Related Issues
Refs #19187