Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notes to Style Guide about "you" as a subject #18471

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

marcysutton
Copy link
Contributor

Description

We've seen a few PRs come in as part of #18284 that highlighted the need for more context in the Gatsby Style Guide around the subject of docs. This PR makes that change, including some of the text needed for #18424 (without having to wait for it to be ready to merge)

@marcysutton marcysutton requested a review from a team as a code owner October 10, 2019 19:15
@marcysutton
Copy link
Contributor Author

cc @gillkyle, since #18470 prompted me to push this change separately

@marcysutton
Copy link
Contributor Author

This one too -- I didn't get a chance to submit my comments before it was merged #18466

Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great clarification 👍

@marcysutton
Copy link
Contributor Author

Thanks, Kyle!

@marcysutton marcysutton merged commit 9323181 into master Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-style-guide branch October 10, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants