Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(showcase): Move creator image to correct directory #17639

Merged
merged 1 commit into from
Sep 15, 2019

Conversation

m-allanson
Copy link
Contributor

@m-allanson m-allanson commented Sep 15, 2019

Description

Move image to correct location

Edit (thanks for the reminder @pranshuchittora): this was added in the linked PR, but in the wrong location. This meant that building gatsbyjs.org would fail trying to load a non-existent image.

Related Issues

#17600

@m-allanson m-allanson requested review from a team as code owners September 15, 2019 08:32
Copy link
Contributor

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls provide the description about the changes OR follow the PR template

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit ff216b3 into master Sep 15, 2019
@LekoArts LekoArts deleted the fix-creator-image branch September 15, 2019 18:21
LOLdevelopr pushed a commit to LOLdevelopr/gatsby-1 that referenced this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants