Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-transformer-react-docgen): vendor in react-docgen-displayname-handler #16913

Merged
merged 6 commits into from
Aug 30, 2019

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Aug 21, 2019

Description

Vendors this particular handler so it's easier to keep up to date. The original project is fairly dead, and this seems easier/better than trying to revive it given how little code there is. Should remove some peer dep warnings

Related Issues

@jquense jquense requested a review from a team as a code owner August 21, 2019 14:20
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for vendoring this package. A few comments on the test.

@wardpeet wardpeet changed the title feat: vendor in the displayname handler to keep it up to date Aug 21, 2019
@jquense
Copy link
Contributor Author

jquense commented Aug 21, 2019

oops, updated

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jquense, tests are passing so I hope it's all good!

@wardpeet wardpeet merged commit f3b540b into master Aug 30, 2019
@wardpeet wardpeet deleted the vendor-displayname branch August 30, 2019 15:22
waltercruz pushed a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants