Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Don't show deprecation warning when adding children fields with extension #16559

Merged
merged 1 commit into from
Aug 12, 2019
Merged

fix(gatsby): Don't show deprecation warning when adding children fields with extension #16559

merged 1 commit into from
Aug 12, 2019

Conversation

stefanprobst
Copy link
Contributor

We currently show a deprecation warning even when children fields were explicitly added with @childOf(types: ["Parent"]).

Fixes #16550
@stefanprobst stefanprobst requested a review from a team as a code owner August 12, 2019 16:04
@sidharthachatterjee sidharthachatterjee changed the title fix: Don't show deprecation message when children fields added with extension Aug 12, 2019
sidharthachatterjee
sidharthachatterjee approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stefanprobst 💜
@sidharthachatterjee sidharthachatterjee merged commit 5c7a3e1 into gatsbyjs:master Aug 12, 2019
@stefanprobst stefanprobst deleted the fix-childof-false-deprecation-warning branch August 13, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@stefanprobst @sidharthachatterjee