Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Filter manual approval job to apply only to master branch #16460

Merged
merged 1 commit into from
Aug 8, 2019
Merged

chore(ci): Filter manual approval job to apply only to master branch #16460

merged 1 commit into from
Aug 8, 2019

Conversation

m-allanson
Copy link
Contributor

@m-allanson m-allanson commented Aug 8, 2019 •
edited
Loading

Description

We don't need this job on most branches. If you don't know what it is, it's a bit mysterious why it doesn't run automatically.

Related Issues

Refs #16414
@m-allanson m-allanson requested a review from a team as a code owner August 8, 2019 12:32
sidharthachatterjee
sidharthachatterjee approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the likelihood of us wanting to deploy other branches to production is very very low so this is fair! 👍
@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 8, 2019
@gatsbybot gatsbybot merged commit cf27d80 into master Aug 8, 2019
@sidharthachatterjee sidharthachatterjee deleted the feat/manual-approve-master-only branch August 8, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
3 participants
@m-allanson @sidharthachatterjee @gatsbybot