feat(build): builds use a chunk group hash #16389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpackCompilationHash has been replaced with a generated named chunk group hash. This reduces that blast radius of changed built files between builds
afenton90
force-pushed
the
topics/webpack-hash-remove
branch
from
6b6b4d8
to
58849a2
Compare
|
Needs more tests. Alex and I will be pairing on these on Tuesday! |
|
Alex and I paired on this some more today and managed to verify the chunk hash behaviour. However, we found that there are edge cases that this doesn't currently handle:
|
|
Closing in favour of #16686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
webpackCompilationHashis currently used inpage-data.json& HTML files to decipher whether the Gatsby app running in the browser is at the same version as the code on the server/CDN.At the moment this hash changes if anything within
./srchas changed between builds. Meaning a 404 file could be changed which would result in allpage-data.json& HTML files being updated even if they have not changed between builds.This causes some issues when using some cloud CDN providers as described in this issue #15872 .
This PR now constructs the
webpackCompilationHashfrom hashes for each named chunk in webpack. Meaning that if a page or any associated files are changed between builds, only those files that have been updated will receive a newwebpackCompilationHash, allowing for diffs to take place between what is hosted in a CDN and what is about to be pushed to a CDN.Related Issues
closes #15872