Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Don't delete 404 page-data so we don't crash build #16354

Merged
merged 1 commit into from
Aug 4, 2019
Merged

fix(gatsby): Don't delete 404 page-data so we don't crash build #16354

merged 1 commit into from
Aug 4, 2019

Conversation

stefanprobst
Copy link
Contributor

We currently crash on build with a warm cache when there is a query in the 404 page, because we delete public/page-data/404.html during bootstrap but expect it is still there later.

Fixes #15273
@stefanprobst stefanprobst requested a review from a team as a code owner August 3, 2019 18:47
wardpeet
wardpeet approved these changes Aug 4, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @stefanprobst. THanks for fixing! 💪
@wardpeet wardpeet merged commit a2855b3 into gatsbyjs:master Aug 4, 2019
@stefanprobst stefanprobst deleted the dont-crash-404-query branch August 4, 2019 08:35
@wardpeet
Copy link
Contributor

wardpeet commented Aug 5, 2019

Fixed in gatsby@2.13.51
@stefanprobst stefanprobst mentioned this pull request Aug 9, 2019
Closed
@wardpeet wardpeet mentioned this pull request Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@stefanprobst @wardpeet