Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Allow all dateformat options as directive args #16335

Merged
merged 1 commit into from
Aug 3, 2019
Merged

feat(gatsby): Allow all dateformat options as directive args #16335

merged 1 commit into from
Aug 3, 2019

Conversation

stefanprobst
Copy link
Contributor

We currently only have locale and formatString as config arguments for the @dateformat extension. This PR adds fromNow and difference.
@stefanprobst stefanprobst requested a review from a team as a code owner August 2, 2019 16:12
DSchau
DSchau approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- let's do it. Thanks @stefanprobst!
@DSchau DSchau merged commit 1a02b85 into gatsbyjs:master Aug 3, 2019
@stefanprobst stefanprobst deleted the more-dateformat-directive-defaults branch August 3, 2019 08:01
@wardpeet
Copy link
Contributor

wardpeet commented Aug 5, 2019

Published in gatsby@2.13.51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@stefanprobst @wardpeet @DSchau