fix(gatsby): Handle missing match-paths.json in serve #16246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Jul 31, 2019
sidharthachatterjee
approved these changes
Aug 1, 2019
sidharthachatterjee
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby serveuses thematch-paths.jsonfile from Gatsby's.cachedirectory to configure client side routing. It assumes that file always exists. If that file doesn't exist, the error bubbles up to the cli's generic fail handling code.This results in a confusing error as seen in #16092.
This PR adds a warning if
match-paths.jsondoesn't exist:Related Issues
Fixes #16092