Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-plugin-mdx): Don't inline typedefs #16229

Merged
merged 1 commit into from
Jul 30, 2019
Merged

chore(gatsby-plugin-mdx): Don't inline typedefs #16229

merged 1 commit into from
Jul 30, 2019

Conversation

stefanprobst
Copy link
Contributor

Don't inline the type definitions for wordCount
This is not super important, but the advantage is that non-inlined typedefs are available early in the type registry -- inlined only when building the schema.
@stefanprobst stefanprobst requested a review from a team as a code owner July 30, 2019 20:18
sidharthachatterjee
sidharthachatterjee approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sidharthachatterjee sidharthachatterjee merged commit 15ae936 into gatsbyjs:master Jul 30, 2019
@stefanprobst stefanprobst deleted the no-inline-mdx-types branch July 31, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@stefanprobst @sidharthachatterjee