Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Fix special case id:eq queries for abstract types #16114

Merged
merged 2 commits into from
Jul 30, 2019
Merged

fix(gatsby): Fix special case id:eq queries for abstract types #16114

merged 2 commits into from
Jul 30, 2019

Conversation

stefanprobst
Copy link
Contributor

We treat queries with a filter that only consists of id: { eq: "someID" } as a special case. This special casing does not yet handle abstract types (interfaces). This PR fixes that.

Fixes #16021
@stefanprobst stefanprobst requested a review from a team as a code owner July 26, 2019 08:05
@stefanprobst stefanprobst changed the title Fix special case id:eq queries for abstract types Jul 26, 2019
@ChristopherBiscardi ChristopherBiscardi mentioned this pull request Jul 28, 2019
Closed
sidharthachatterjee
sidharthachatterjee approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇
@sidharthachatterjee sidharthachatterjee merged commit 6d8b663 into gatsbyjs:master Jul 30, 2019
@stefanprobst stefanprobst deleted the fix-eqid-special-casing branch July 31, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@stefanprobst @sidharthachatterjee