-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-transformer-react-docgen): upgrade to react-docgen 5 #16094
Conversation
yup to ya'll whether this counts as a breaking change. Strictly speaking some users will be broken tho |
ping |
BREAKING CHANGE: maybe, the interal api's chagned so folks using custom resolvers will probably be broken, but generally the default user should be unaffected
43b836e
to
4015e15
Compare
@jquense Thank you for doing this! The new release looks great (TypeScript support 😍) I would definitely want to release this as a major version bump (owning to the breaking changes in the resolver signature documented in https://github.com/reactjs/react-docgen/releases/tag/v5.0.0-beta.1 and the fact that we document the custom resolver option in https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-transformer-react-docgen/README.md) Shall we wait till |
that is likely to be months at the pace the project tends to move, integers are cheap, so why wait, can always bump again if needed. Up to ya'll but i've published my own version for now so we can get typescript support |
@jquense Fair enough! I’ll get this published as a major today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in! Thank you so much @jquense 🥇
Published in |
🎉 Thanks! |
BREAKING CHANGE: maybe, the interal api's chagned so folks using custom resolvers will probably be broken, but generally the default user should be unaffected
Description
Related Issues