fix(gatsby-transformer-react-docgen): always create description nodes #14876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
suggested changes
Jun 18, 2019
|
oops sorry, missed the template doing the github editor. I don't quite know how i'd unit test this, the "bug" is more in the interaction between gatsby's schema generation than anything the plugin does does. |
|
arg gonna have to actually pull this down sorry |
DSchau
added
status: awaiting author response
|
k this should be good, added some kinda of test as well |
DSchau
removed
status: WIP
status: awaiting author response
|
Fixed in |
m-allanson
added a commit
that referenced
this pull request
Jun 19, 2019
* master: (41 commits) chore(release): Publish fix(gatsby): Normalize paths for run queries before caching (#14910) chore(release): Publish fix(gatsby-cli): add missing node-fetch dependency (#14908) feat(blog): Site Showcase Validator blogpost (#14855) chore(gatsby-remark-graphviz): add --ignore for test directory (#14906) fix(tutorials): rename "advanced" to "additional (#14847) fix(starters): update gatsby monorepo (#14886) chore(starters): Switch to useStaticQuery (#14857) chore(release): Publish Add status bar to bottom of screen during develop (#14874) chore(release): Publish fix(*): fix gatsby-cli dep in source-filesystem & plugin-sharp (#14881) docs(www): 25 Workflows - Embedding components in Markdown with MDX (#14543) docs(blog): add case study blog post for The Couch / Prima (#14871) docs(www): 25 Workflows - Adding CSS and/or Sass (#14779) fix(gatsby-transformer-react-docgen): always create description nodes (#14876) chore(release): Publish chore(gatsby): revert progressbar functionality (#14884) Revised "winning over engineering leaders" Docs page (#14830) ...
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
…gatsbyjs#14876) * fix: always create description nodes * Update on-node-create.js * fix tests
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
…gatsbyjs#14876) * fix: always create description nodes * Update on-node-create.js * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gatsby started warning about
descriptionbeing resolved by two fields. In practice what was happening is that sometimes it'd just be the inferred string and other times the node here. This changes ensures that description is always aComponentDescriptionnodeRelated Issues