refactor(gatsby-cli): update reporter to support different implementations #13497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
added
the
status: awaiting reviewer response
sidharthachatterjee
approved these changes
Apr 25, 2019
sidharthachatterjee
changed the title
sidharthachatterjee
removed
the
status: awaiting reviewer response
|
Published in |
muescha
reviewed
Apr 25, 2019
| const { trackError } = require(`gatsby-telemetry`) | ||
|
|
||
| const VERBOSE = process.env.gatsby_log_level === `verbose` | ||
| const reporterInstance = require(`./reporters/yurnalist`) |
There was a problem hiding this comment.
this is very tight binding to yurnalist? you change this later to a setting?
There was a problem hiding this comment.
Yup, incrementally!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically this is just a refactor to allow us to fallback to yurnalist when people are on node 6. We can also fallback on CI as Gatsby Cloud would need this as we don't write to stderr (I think) when using ink.
In this PR it's only using yurnalist to make sure we don't break anything and keep this PR small. Ink will build from this one.
Related PRs
#13089