Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-remark): restore behavior of serializing date-like fields to string #11716

Merged
merged 6 commits into from
Feb 12, 2019
Merged

fix(gatsby-transformer-remark): restore behavior of serializing date-like fields to string #11716

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc50ffb
chore: commit
DSchau Feb 8, 2019
5962f39
chore: get tests failing (intentionally) to then fix
DSchau Feb 8, 2019
88e5e2b
chore: de-dry
DSchau Feb 8, 2019
32da61a
chore: finish tests
DSchau Feb 12, 2019
dbdca86
Merge remote-tracking branch 'upstream/master' into gatsby-transforme…
DSchau Feb 12, 2019
37d2c60
chore: revert relative import
DSchau Feb 12, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: de-dry
  • Loading branch information
@DSchau
DSchau committed Feb 8, 2019
commit 88e5e2bb6168aa6ca5654f28a7ef0f84bbfcac55
39 changes: 26 additions & 13 deletions packages/gatsby-transformer-remark/src/__tests__/on-node-create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,36 +107,49 @@ date: ${date}

yadda yadda
`
const setup = mdNode =>
onCreateNode({
node: mdNode,
it(`coerces a date a date object`, async () => {
node.content = getContent(`2019-01-01`)
const parsed = await onCreateNode({
node,
actions,
createNodeId,
loadNodeContent,
})
it(`coerces a date a date object`, async () => {
node.content = getContent(`2019-01-01`)
const parsed = await setup(node)

expect(parsed.frontmatter.date).toEqual(expect.any(Date))
})

it.skip(`coerces a date string into a date object`, async () => {
node.content = getContent(JSON.stringify(`2019-01-01`))
const parsed = await setup(node)
const parsed = await onCreateNode({
node,
actions,
createNodeId,
loadNodeContent,
})

expect(parsed.frontmatter.date).toEqual(expect.any(Date))
})

it.skip(`parses date fields and date strings into the same date`, async () => {
const [uno, dos] = await Promise.all([
setup({
...node,
content: getContent(`2019-01-01`),
onCreateNode({
node: {
...node,
content: getContent(`2019-01-01`),
},
actions,
createNodeId,
loadNodeContent,
}),
setup({
...node,
content: getContent(JSON.stringify(`2019-01-01`)),
onCreateNode({
node: {
...node,
content: getContent(JSON.stringify(`2019-01-01`)),
},
actions,
createNodeId,
loadNodeContent,
}),
])

Expand Down