chore(gatsby-transformer-remark): bump underscore.string version

[saranshkataria]

Description

Removed underscore.string from gatsby-transformer-remark and replaced it with lodash truncate

Related Issues

Fixes #10958

[DSchau]

Left a comment, but this looks good. All in favor of moving off of underscore where we can!

[wardpeet]

@saranshkataria Sadly we're not having the same output as underscore.
I've made a glitch to demonstrate the failures. I've used underscore's test as a baseline.
https://glitch.com/edit/#!/solar-mechanic

I think the best way is just to mimic the underscore code in gatsby if we want to get rid of underscore.
https://github.com/epeli/underscore.string/blob/master/prune.js

[pieh]

Can we just bump version of underscore.string? It's fixed and even now only way to have old version installed is if lock file locks it down (because version range selector allow installing updated version)?

ref: https://www.npmjs.com/advisories/745

[saranshkataria]

I tried to make the functionality similar to that of prune, but was not able to. Reverted the changes and bumped up the underscore version for now to fix the original issue. Will give removing underscore another shot sometime later.

PR was changed to bump underscore.string

[pieh]

LGTM, let's ship it! Thanks @saranshkataria for exploring options here!

[gatsbot]

Holy buckets, @saranshkataria — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!