Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] graphql schema refactor #10995

Closed
wants to merge 124 commits into from

Conversation

stefanprobst
Copy link
Contributor

See #4261

@stefanprobst
Copy link
Contributor Author

@freiksenet Thanks for your comments! I think I should start by saying that I have been working on this branch as a hobby learning project, and literally the first thing I did was delete everything in the schema/ folder and start from scratch. So it's probably best to not base the schema refactor off of this, but view it more as a working prototype to take some ideas from, especially if we want to keep this as minimally invasive as possible.
I'm really motivated to help with that (and also appreciate feedback) but let's close this and do it properly?

As for the rest, comments inline.

@freiksenet
Copy link
Contributor

@stefanprobst Sounds good :) I think the minimal PR would have graphql-compose backed schema, addTypeDefs and addResolvers functions and maybe the model layer. I probably won't have much time to work on it next week, but I can start or help with it after that. Looking forward to the call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants