Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-remark): don't convert Date objects #10924

Merged
merged 2 commits into from
Jan 25, 2019
Merged

fix(gatsby-transformer-remark): don't convert Date objects #10924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc53066
Allow YAML 1.2 types only
stefanprobst Jan 8, 2019
3bd4915
Revert to 1.1 spec
stefanprobst Jan 8, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions packages/gatsby-transformer-remark/src/on-node-create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
const grayMatter = require(`gray-matter`)
const crypto = require(`crypto`)
const _ = require(`lodash`)

module.exports = async function onCreateNode(
{ node, getNode, loadNodeContent, actions, createNodeId, reporter },
{ node, loadNodeContent, actions, createNodeId, reporter },
pluginOptions
) {
const { createNode, createParentChildLink } = actions
Expand All @@ -19,18 +18,7 @@ module.exports = async function onCreateNode(
const content = await loadNodeContent(node)

try {
let data = grayMatter(content, pluginOptions)
// Convert date objects to string. Otherwise there's type mismatches
// during inference as some dates are strings and others date objects.
if (data.data) {
data.data = _.mapValues(data.data, v => {
if (_.isDate(v)) {
return v.toJSON()
} else {
return v
}
})
}
const data = grayMatter(content, pluginOptions)

const markdownNode = {
id: createNodeId(`${node.id} >>> MarkdownRemark`),
Expand Down