Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(starter-library): add example to starter library #10425

Merged
merged 5 commits into from
Dec 12, 2018
Merged

docs(starter-library): add example to starter library #10425

merged 5 commits into from
Dec 12, 2018

Conversation

robertcoopercode
Copy link
Contributor

Adding an example the the Gatsby starter library 📝

@robertcoopercode robertcoopercode requested a review from a team December 12, 2018 04:02
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for sharing your starter. I left a few comments you need to address 👍

docs/starters.yml Outdated Show resolved Hide resolved
docs/starters.yml Outdated Show resolved Hide resolved
docs/starters.yml Outdated Show resolved Hide resolved
docs/starters.yml Outdated Show resolved Hide resolved
LekoArts and others added 4 commits December 12, 2018 10:09
Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>
Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>
Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>
Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>
@robertcoopercode
Copy link
Contributor Author

Thanks for the quick review @LekoArts. I've updated the PR with your suggested changed.

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@LekoArts LekoArts merged commit 3ba82a3 into gatsbyjs:master Dec 12, 2018
m-allanson added a commit to Bouncey/gatsby that referenced this pull request Dec 14, 2018
* master: (33 commits)
  fix(blog): youfit case study typofix
  Doc improvements to Visual testing with Storybook guide (gatsbyjs#10436)
  fix(gatsby-plugin-offline): prevent incorrect revisioning of static file by workbox (gatsbyjs#10416)
  fix(starters): ttag repo link
  fix typo in pull request template (gatsbyjs#10454)
  fix(www) Fix query for plugin links always ?=undefined (gatsbyjs#10453)
  chore(release): Publish
  fix(gatsby): fix extracting StaticQuery nested in shorthand fragment (gatsbyjs#10443)
  fix(www): avoid querying for no-cache=1 (gatsbyjs#10389)
  fix(gatsby-image): update typescript definitions - properly mark fields as optional (gatsbyjs#10419)
  refactor(gatsby): improve EnsureResources (gatsbyjs#10224)
  Fixed minor Typos and grammatical errors (gatsbyjs#9353)
  docs: add ClinciJS website into showcase (gatsbyjs#10437)
  docs(babel-preset-gatsby): document --save-dev flag in README (gatsbyjs#10434)
  fix(docs): Environment Variables Examples (gatsbyjs#10406)
  chore(release): Publish
  [gatsby-image] re: fade out base64 on full image load (gatsbyjs#7539)
  docs(starter-library): add example to starter library (gatsbyjs#10425)
  docs(gatsby-plugin-offline): specify to not HTTP-cache sw.js (gatsbyjs#10430)
  fix(docs): prompt => confirm (gatsbyjs#10431)
  ...
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* docs(starter-library): add example to starter library

* docs: update Netlify CMS spelling

Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>

* docs: rename Sass tag

Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>

* docs: remove 'responsive' tag

Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>

* docs: remove 'Gatsby V2' tag

Co-Authored-By: robertcoopercode <robert.cooper.qu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants