Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Make nodes fully immutable by adding API for allowing plugins to add fields #1035

Merged
merged 17 commits into from
May 26, 2017
Merged

[1.0] Make nodes fully immutable by adding API for allowing plugins to add fields #1035

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
449173e
remove updateNode action creator, rename 'pluginName' to 'pluginOwner…
KyleAMathews May 24, 2017
cdf2539
Add top-level field to nodes 'pluginFields'
KyleAMathews May 24, 2017
f9faf17
Replace 'updateNode' action creator with 'addChildNodeToParentNode' a…
KyleAMathews May 24, 2017
7cdbda6
Add test for nodes being created with field 'pluginFields'
KyleAMathews May 24, 2017
b8317cf
Use stripIndent so multiline strings look nicer in code
KyleAMathews May 25, 2017
62bbd99
Rename addChildNodeToParentNode to addNodeToParent
KyleAMathews May 25, 2017
d89607f
Update transformer tests
KyleAMathews May 25, 2017
918003a
Fixed bit of code that didn't get updated for node structure refactor
KyleAMathews May 25, 2017
8f77c1a
Simplify error message
KyleAMathews May 25, 2017
a31d391
Check if there's actually results so avoiding access error
KyleAMathews May 25, 2017
54d271b
Test nodes often don't have internal set
KyleAMathews May 26, 2017
e883aa1
Rename 'pluginFields' to 'fields'
KyleAMathews May 26, 2017
f44aa4b
Rename other fields with 'plugin' in them
KyleAMathews May 26, 2017
9e23038
Merge branch '1.0' into immutable-fields
KyleAMathews May 26, 2017
c847be1
Update migration guide with changes
KyleAMathews May 26, 2017
02a8ac3
Update gatsbygram example code to wrap graphql call in resolve
KyleAMathews May 26, 2017
a57cbc2
Update snapshot
KyleAMathews May 26, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify error message
  • Loading branch information
@KyleAMathews
KyleAMathews committed May 25, 2017
commit 8f77c1acc681b617932238a5595ef6d0264ff96f
11 changes: 2 additions & 9 deletions packages/gatsby/src/redux/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,10 @@ actions.createNode = (node, plugin) => {
if (oldNode && oldNode.internal.pluginOwner !== plugin.name) {
throw new Error(
stripIndent`
Nodes can only be updated by their owner. Node ${node.id} is
owned by ${oldNode.internal.pluginOwner} and another plugin ${plugin.name}
Nodes can only be updated by their owner. Node "${node.id}" is
owned by "${oldNode.internal.pluginOwner}" and another plugin "${plugin.name}"
tried to update it.

Node:

${JSON.stringify(node, null, 4)}

Plugin that tried to update the node:

${JSON.stringify(plugin, null, 4)}
`
)
}
Expand Down