Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Combine "transformer" and "typegen" plugins #918

Closed
KyleAMathews opened this issue May 4, 2017 · 1 comment
Closed

[1.0] Combine "transformer" and "typegen" plugins #918

KyleAMathews opened this issue May 4, 2017 · 1 comment

Comments

@KyleAMathews
Copy link
Contributor

The distinction between the two has proved somewhat artificial so I'm going to combine them.

The distinction originally was that "transformer" (or as known previously "parser") plugins were to sketch the outlines of the various data nodes but avoid expensive work leaving that for the typegen plugins. So for markdown, the remark parser would parse the frontmatter but not parse the markdown source as that's a lot more expensive leaving that for the typegen-remark plugin.

So while that performance tradeoff I still think makes a lot of sense, splitting the code into different modules doesn't as the two types of plugins are completely coupled and have to be installed together.

Which is confusing and unnecessary :-)

So let's eliminate it!

Should be mostly a bunch of pushing bits around so I should be able to get this done later.
KyleAMathews added a commit that referenced this issue May 5, 2017
@KyleAMathews
[1.0] Combine typegen and transformer plugins fixes #918 (#926)
e4457d1 
* Move files around to remove typegen plugins

* Update example websites

* Remove yarn.lock on build server so sites get latest

* Update yarn.lock
@KyleAMathews
Copy link
Contributor Author

Fixed by #926
ide pushed a commit to expo/expo that referenced this issue Dec 19, 2018
@KyleAMathews @ide
[expo-docs] Update to Gatsby 1.0.0-alpha14
2ceb0b2 
Some package renaming ( is deprecated as a concept/name — see gatsbyjs/gatsby#918) + lots of bug fixes + cache invalidation when plugins change.

Also potentially interesting for y'\''all in the future is Gatsby is now using Relay'\''s graphql compiler which lets you compose graphql queries together. So individual components can have a query and those get composed together on page components.

Closes expo/expo-docs#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@KyleAMathews