-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL query results incorrect after upgrade from gatsby@1.9.210 to 1.9.211 #4385
Comments
I can confirm I'm seeing the same thing using your starter. See here for the full diff between If you'd like to investigate a fix there's some instructions on setting up a dev environment for Gatsby. (I edited your comment to put the GraphQL results into collapsible blocks) |
Looking into this... |
Curious why it hasn't shown up on gatsbyjs.org since we use basically the same query. |
Turns out the problem was how we were generating a cache key. I only used the node's contentDigest. Which is fine for organic content since people will almost never have identical content but falls apart for demo stuff like this as you do have some duplicate markdown files. You also uncovered another bug — which if it hadn't existed wouldn't have uncovered the above bug — which is that |
As soon as the tests finish running I'll merge and release the fix. Thanks for the through bug report! |
Great! Thank you for the quick intervention. |
Description
I wanted to release my new Gatsby starter gatsby-starter-personal-blog, but before that I wanted to update gatsby and its plugins to the latest. I was working during the development with Gatsby 1.9.192.
Regrettably I can't. Every other packages are ok, but not the Gatsby itself. Upgrading to anything later than 1.9.210 blows my work. After upgrade Gatsby to 1.9.211, my GraphQL queries results going crazy.
For example, this testing query
on 1.9.210 gives correct result:
Expand to see full result
but after update to 1.9.211 the same query gives broken list with some edges omitted and some multiplied:
Expand to see full result
I believe that it's connected with the Fixes to speed up running queries — add caching & avoid work (#4213) commit, but I'm not sure about that, just tested different versions of Gatsby and the 1.9.210 is the last one it works with.
Steps to reproduce
gatsby new test-issue https://github.com/greglobinski/gatsby-starter-personal-blog.git
gatsby develop
to check the redered list of posts or try the test query from aboveyarn add gatsby@1.9.211
gatsby develop
and check the differenceEnvironment
Question
The starter is ready to release, but I do not want to do it with this flaw "You can use the starter but forget about updating Gatsby" ;) For now I can't figure out what/where is the problem and how to fix it. I appreciate any tips.
The text was updated successfully, but these errors were encountered: