Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Responsive images: ignore SVG's #1145

Closed
rstacruz opened this issue Jun 11, 2017 · 3 comments
Closed

[1.0] Responsive images: ignore SVG's #1145

rstacruz opened this issue Jun 11, 2017 · 3 comments
Labels
type: question or discussion Issue discussing or asking a question about Gatsby

Comments

@rstacruz
Copy link
Contributor

I think SVG's should be ignored from the responsive images pipeline. They should be responsive by it's default nature, shouldn't they? :)

![](example.svg)
@jbolda jbolda added API/Plugins type: question or discussion Issue discussing or asking a question about Gatsby labels Jun 11, 2017
@KyleAMathews
Copy link
Contributor

True! :-) Could you make a PR to exclude it like gifs? And make the copy-link plugin copy over svgs.
@fk
Copy link
Contributor

fk commented Jun 12, 2017 via email

@fk fk mentioned this issue Jun 13, 2017
Merged
KyleAMathews pushed a commit that referenced this issue Jun 13, 2017
@fk @KyleAMathews
[1.0] Ignore SVGs in gatsby-remark-responsive-image (#1145) (#1157)
51bdc9d 
* Ignore SVGs in gatsby-remark-responsive-image

…and instead just copy them alongside GIFs in gatsby-remark-copy-linked-files.

* Fix reference to node `contentDigest`

@see #960
@see https://github.com/gatsbyjs/gatsby/releases/tag/v1.0.0-alpha15

* Check node extension instead of sliced image.url
@fk
Copy link
Contributor

fk commented Jun 23, 2017

@KyleAMathews This can be closed, sorry for not doing so in the commit message.
This was referenced Jan 21, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about Gatsby
4 participants
@fk @KyleAMathews @rstacruz @jbolda