fix(gatsby): Add error message for field extension validation (#16232)

gatsbyjs · Jul 30, 2019 · f64a9e0 · f64a9e0
1 parent 6d8b663
commit f64a9e0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/gatsby/src/schema/infer/__tests__/merge-types.js b/packages/gatsby/src/schema/infer/__tests__/merge-types.js
@@ -588,7 +588,7 @@ describe(`merges explicit and inferred type definitions`, () => {
           links: {
             type: `[Test!]!`,
             extensions: {
-              link: true,
+              link: {},
             },
           },
         },

diff --git a/packages/gatsby/src/schema/schema.js b/packages/gatsby/src/schema/schema.js
@@ -392,6 +392,15 @@ const addExtensions = ({
         .filter(name => !internalExtensionNames.includes(name))
         .forEach(name => {
           const args = fieldExtensions[name]
+
+          if (!args || typeof args !== `object`) {
+            report.error(
+              `Field extension arguments must be provided as an object. ` +
+                `Received "${args}" on \`${typeName}.${fieldName}\`.`
+            )
+            return
+          }
+
           try {
             const definition = schemaComposer.getDirective(name)