Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements and control changes to the CPU flame chart #5529

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Performance improvements and control changes to the CPU flame chart #5529

merged 4 commits into from
Mar 27, 2023

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Mar 27, 2023 •
edited
Loading

Please review with hide whitespace enabled.

This PR:

  • changes the flame chart widget to use the WASD zooming and navigation controls only instead of the scroll-to-zoom controls (this is consistent with the Perfetto trace viewer and other tools)
  • improves the performance of the flame chart by minimizing the quantity of MouseRegion and GestureDetector widgets in the flame chart. We were previously using one MouseRegion and GestureDetector per row, and now we are using one for the entire flame chart.
  • Switches from RawKeyboardEventListener to Focus widget to properly handle key events. Eliminates "pop" noise due to the key event not being marked as handled.
@kenzieschmoll kenzieschmoll requested a review from a team as a code owner March 27, 2023 18:30
@kenzieschmoll kenzieschmoll requested review from polina-c and removed request for a team March 27, 2023 18:30
@kenzieschmoll kenzieschmoll merged commit 11a48f2 into flutter:master Mar 27, 2023
@kenzieschmoll kenzieschmoll deleted the flame-chart-scrolling branch March 27, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@kenzieschmoll @bkonyi