Point users to Impeller from shader compilation warnings on iOS #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,8 @@ void debugTraceEventCallback(VoidCallback callback) { | |||
|
|
|||
| const preCompileShadersDocsUrl = 'https://docs.flutter.dev/perf/shader'; | |||
|
|
|||
| const impellerWikiUrl = 'https://github.com/flutter/flutter/wiki/Impeller'; | |||
There was a problem hiding this comment.
@zanderso / @chinmaygarde are we keeping the wiki as the canonical source of documentation for Impeller?
There was a problem hiding this comment.
If there is a better link to point users to, let me know and I will change in a follow up PR. Thanks.
There was a problem hiding this comment.
Yeah the wiki link is fine for now. If/when we shift to flutter.dev, we'll file an issue to update and also put a forwarding link in the wiki.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The note suggesting that users try Impeller will only show up when the connected app is running on iOS. The Impeller link takes users to the wiki.
Fixes #5349
CC @chinmaygarde @dnfield @jonahwilliams