-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DevTools to Material 3 #5429
Conversation
Some places that need UI polish: There's some places where the border outline is cut off at the corners (debugger call stack, file explorer, network requests table, logging, etc): and some buttons with colored backgrounds have invisible text (connection screen, device info dialog): Text is unreadable in the heap snapshot tab: We need some padding between the "Clear" and "(?)" buttons under the trace instances tab: The "File Explorer" button on the debugger page should be a toggle button: |
@kenzieschmoll do you know if these material changes would fix this failure on master? |
Those failures look unrelated. Those are for case study apps. Something probably is broken with those apps on the the latest version of the flutter candidate. |
For now kenzie is adding a release notes exception to the description to overcome a bug in the release notes workflow. Essentially this PR has so many files, and the workflow doesn't support pagination when fetching the list of files modified :P :D |
I added fixes for this to this PR. Just changed a couple min sdk constraints on the test fixture and case study apps |
@kenzieschmoll I tried this out in VS Code embedded view. Noticed a few minor issues (not sure if they're all related to this change though, or if any are dupes). If you'd rather another issue(s) for these, let me know.
|
Fixes #4601
There is still some polish to land as a follow up and some TODOs I will address, but this is the bulk of the migration.
RELEASE_NOTE_EXCEPTION=[release notes are modified - there is a bug in the check]