Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug Logging #5404

Merged
merged 45 commits into from
Mar 16, 2023
Merged

Add Debug Logging #5404

merged 45 commits into from
Mar 16, 2023

Conversation

CoderDake
Copy link
Contributor

@CoderDake CoderDake commented Mar 13, 2023

This PR adds a new way for us to save debug logs, and make them easily accessible to the user.

The user will now have the ability to turn on "Verbose Logging" which will enable info logs, allowing us to give detail and insights into what is going on for the user.

Interesting things added:

  • all of our log messages will also be added to these Debug logs
  • I've added a logging wrapper around trackFuture so that we can get insights into what vmService requests are happening
  • I've added rudimentary logs for when select and screen analytics events are happening. This should give us a basic idea of what the user is doing while they are running into issues.
  • I've added an error handler for the root isolate, so that we now log errors there too (they were previously just being ignored

TODO

  • Add Release Notes
@CoderDake CoderDake requested a review from a team as a code owner March 13, 2023 20:15
@CoderDake CoderDake requested review from bkonyi and removed request for a team March 13, 2023 20:15
@CoderDake CoderDake requested a review from bkonyi March 15, 2023 20:19
@CoderDake CoderDake requested a review from bkonyi March 16, 2023 18:05
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple comments

@CoderDake CoderDake merged commit b79fe2d into flutter:master Mar 16, 2023
@CoderDake CoderDake deleted the better-logging branch March 16, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants