-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debug Logging #5404
Merged
Merged
Add Debug Logging #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Mar 16, 2023
packages/devtools_app/lib/src/shared/config_specific/logger/logger_helpers.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Mar 16, 2023
packages/devtools_app/lib/src/shared/analytics/_analytics_web.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new way for us to save debug logs, and make them easily accessible to the user.
The user will now have the ability to turn on "Verbose Logging" which will enable
info
logs, allowing us to give detail and insights into what is going on for the user.Interesting things added:
log
messages will also be added to these Debug logstrackFuture
so that we can get insights into what vmService requests are happeningselect
andscreen
analytics events are happening. This should give us a basic idea of what the user is doing while they are running into issues.TODO