Add Method Table to CPU profiler #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
author Kenzie Schmoll <kenzieschmoll@google.com> 1678230010 -0800 committer Kenzie Schmoll <kenzieschmoll@google.com> 1678235124 -0800 parent ee98f44 author Kenzie Schmoll <kenzieschmoll@google.com> 1678230010 -0800 committer Kenzie Schmoll <kenzieschmoll@google.com> 1678235093 -0800 Make FlatTable scrollable when there is a single wide column revert test change fix up table formatting formatting size method table to fit Add Method Table to the CPU Profiler
bkonyi
reviewed
Mar 8, 2023
packages/devtools_app/lib/src/screens/profiler/panes/method_table/method_table_model.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Mar 9, 2023
| @@ -38,6 +39,8 @@ class CpuMethodTable extends StatelessWidget { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(kenz): ensure that this table automatically scrolls to the selected | |||
There was a problem hiding this comment.
If you select a method from anywhere in the method graph (callees and callers), the graph reroots to that method, which means the method table should scroll to the new selection. We may eventually want to maintain some sort of history here for this reason.
| .round(), | ||
| ); | ||
| /// The number of cpu samples where this method is on top of the stack. | ||
| int get selfCount => _selfCount; |
There was a problem hiding this comment.
Can this just be final int selfCount? Ditto for totalCount.
There was a problem hiding this comment.
_selfCount and _totalCount are non-final because they are modified in the merge method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841