Add profile stats to the CPU profiler #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Mar 2, 2023
| @@ -365,224 +367,62 @@ class _CpuProfilerState extends State<CpuProfiler> | |||
| } | |||
| } | |||
|
|
|||
| class DisplayTreeGuidelinesToggle extends StatelessWidget { | |||
There was a problem hiding this comment.
all the deletes over here were moved to profiler_controls.dart with no functional changes. git diff picked this up weird unfortunately.
kenzieschmoll
commented
Mar 2, 2023
| class DisplayTreeGuidelinesToggle extends StatelessWidget { | ||
| const DisplayTreeGuidelinesToggle(); | ||
| // TODO(kenz): one improvement we could make on this is to show the denominator | ||
| // for filtered profiles (e.g. 'Sample count: 10/14), or to at least show the |
There was a problem hiding this comment.
review all the additions from here to the bottom of the file as new code - not a modification of code on the left.
kenzieschmoll
commented
Mar 2, 2023
| @@ -0,0 +1,241 @@ | |||
| // Copyright 2019 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
no functional changes to this file. all moves from cpu_profiler.dart
bkonyi
approved these changes
Mar 2, 2023
packages/devtools_app/lib/src/screens/profiler/panes/controls/profiler_controls.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3861
While I was here, I also created a new file
profiler_controls.dartand pulled some controls from cpu_profiler.dart out into the new file. This was to make the cpu_profiler.dart file more manageable.