Use the default Flutter service worker instead of our custom service worker #5331
Conversation
| @@ -403,8 +403,7 @@ class FakeVmServiceWrapper extends Fake implements VmServiceWrapper { | |||
| ) async { | |||
| final httpProfile = await getHttpProfile(isolateId); | |||
| return Future.value( | |||
| httpProfile.requests | |||
| .firstWhereOrNull((request) => request.id == id), | |||
| httpProfile.requests.firstWhereOrNull((request) => request.id == id), | |||
There was a problem hiding this comment.
This change was due to running dart format from the root
packages/devtools_app/web/index.html
Outdated
| onEntrypointLoaded: function(engineInitializer) { | ||
| engineInitializer.initializeEngine().then(function(appRunner) { | ||
| appRunner.runApp(); | ||
| }); |
There was a problem hiding this comment.
can you set the config to use canvas kit here now that we are using the default service worker?
https://docs.flutter.dev/development/platform-integration/web/renderers#runtime-configuration.
This would also allow us to remove --dart-define=FLUTTER_WEB_CANVASKIT_URL=canvaskit/ \ from build_release.sh below.
Here is the devtools issue for that: #5148
packages/devtools_app/web/index.html
Outdated
| onEntrypointLoaded: function(engineInitializer) { | ||
| engineInitializer.initializeEngine({ | ||
| renderer: 'canvaskit', | ||
| canvasKitBaseUrl: 'canvaskit' |
There was a problem hiding this comment.
curious, does the call to initializeEngine work without setting the base url? In the example on the flutter website, I only saw "renderer" specified, so I'm wondering why we need this too
There was a problem hiding this comment.
Yep, looks like this is required otherwise it tries to download canvaskit from the CDN, which is surprising. Opened flutter/flutter#121743 in Flutter
|
Fixes #5148 |
Yep, all is working (even with no internet connection) |
Work towards #3896, #4658
Use the default Flutter service worker generated by Flutter Web instead of our own.
index.htmlwere copied from the defaultindex.htmlgenerated by Flutter when you runflutter createpwa-strategychanged fromnonetooffline-firstso that Flutter generates a service workerConfirmed that the new service worker works by running
dart run tool/build_e2e.dart. Need to also update the copybara script before submitting.