Update model to 1.5-pro #1611
Merged
Update model to 1.5-pro #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
reviewed
May 11, 2024
Comment on lines
+56
to
61
| // Initialize a GenerativeModel with the `gemini-pro` AI model | ||
| // for multimodal text generation | ||
| val generativeModel = Firebase.vertexAI.generativeModel( | ||
| modelName = "gemini-1.0-pro-vision", | ||
| modelName = "gemini-1.5-pro-preview-0409", | ||
| generationConfig = config | ||
| ) |
There was a problem hiding this comment.
At this point I think we can initialize the model once (like before the return clause) and then pass to every ViewModel. The reason why I had different initializations was because of gemini-pro-vision. But now that we use the same model for every use case, maybe we could simplify our code?
Stromlight
reviewed
May 11, 2024
thatfiredev
approved these changes
May 13, 2024
thatfiredev
added a commit
that referenced
this pull request
May 13, 2024
* feat: add vertexai quickstart app * style: run ktlint * chore: add vertex ai to mock-google-services.json * add Vertex AI link to main README file * bump gradle to 8.6 * Remove properties not supported by java 17 (#1612) * Update model to 1.5-pro (#1611) --------- Co-authored-by: Rodrigo Lazo <rlazo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.