Loosen SectionList renderItem required return type
#45305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59404511 |
Summary: Pull Request resolved: facebook#45305 Allow SectionList render functions to return any React node, instead of just React.Element. This matches VirtualizedList/FlatList, and general Flow component conventions. Changelog: [General][Fixed] - Loosen SectionList `renderItem` required return type Differential Revision: D59404511
|
This pull request was exported from Phabricator. Differential Revision: D59404511 |
NickGerleman
force-pushed
the
export-D59404511
branch
from
29c1db9
to
203dfa6
Compare
|
This pull request has been merged in 12b64b7. |
|
This pull request was successfully merged by @NickGerleman in 12b64b7. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow SectionList render functions to return any React node, instead of just React.Element. This matches VirtualizedList/FlatList, and general Flow component conventions.
Changelog:
[General][Fixed] - Loosen SectionList
renderItemrequired return typeDifferential Revision: D59404511