Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat[iOS]:- added support for titleFontSize,titleFontFamily and titleFontWeight t… #45283

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Jul 4, 2024

Summary:

Currently the Refresh Control title styles are limited, i have gotten into cases where i want the title size to be big in specific case, font style to be changed as i want including font weight as well, this PR just extend the same functionality and things seem to be working as i tested the same native code in a react native scaffold

Screen.Recording.2024-07-04.at.5.25.28.PM.mov

Changelog:

[iOS] [Added] - Added Support for Refresh Control titleFontSize,titleFontFamily, titleFontWeight

Test Plan:

Tested in a react native scaffold app

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 4, 2024
@Biki-das
Copy link
Contributor Author

Biki-das commented Jul 4, 2024

@Biki-das
Copy link
Contributor Author

Biki-das commented Jul 4, 2024

i definately need a hand solving the flow issues, the androidNativeComponent is complaining even though i have selectively extend the iOS prop types

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,285,090 -22
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,481,869 +10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 261f82e
Branch: main

@cipolleschi
Copy link
Contributor

There are a lot of failures in CI and the code only tackles the Old Architecture.
Could you have a look at them and also implement the same changes in the New Architecture, please? 🙏

@Biki-das
Copy link
Contributor Author

Biki-das commented Jul 9, 2024

yes the Ci fails are mostly flow related, also where is the new arch code, could you just hint me up to the same? is there any additional config to get the new arch code

@cipolleschi
Copy link
Contributor

cipolleschi commented Jul 9, 2024

New arch code should be here.

In general, if there is Fabric or react/renderer/component in the path, you are working on a New Arch file.

To test it, on iOS, just run RCT_NEW_ARCH_ENABLED=1 bundle exec pod install when you install your dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
4 participants