Make DefaultComponentsRegistry the default behaviour for ComponentFactory #45245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory Summary: Merge newarchdefaults jni target into fabric and turbomodule targets. These do not need to be their own shared library, and allows us to simplify things further, like making ComponentFactory default to using the CoreComponentsRegistry + registerComponentDescriptorsFromEntryPoint. Changelog: [Android][Removed] DefaultsComponentRegistry.register is now a no-op, please remove calls to it. Differential Revision: D59269549
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59269549 |
Base commit: ad3df84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Merge newarchdefaults jni target into fabric and turbomodule targets. These do not need to be their own shared library, and allows us to simplify things further, like making ComponentFactory default to using the CoreComponentsRegistry + registerComponentDescriptorsFromEntryPoint.
Changelog: [Android][Removed] DefaultsComponentRegistry.register is now a no-op, please remove calls to it.
Differential Revision: D59269549