Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] [Fix]:-Unify onMomentumEnd callback behaviour in android with iOS #43654

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Android] [Fix]:-Unify onMomentumEnd callback behaviour in android with iOS #43654

wants to merge 3 commits into from

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Mar 26, 2024 •
edited
Loading

Summary:

There is a specific divergent occuring on the onmomentunscrollend occuring in android , the same callback does not called when using the scrolltooffset, in short when we try to scroll programatically , the onmomentumscrollend does not get called, the issue is limited to android and things work fine in iOS

Screen.Recording.2024-03-27.at.1.57.53.PM.mov

Changelog:

[ANDROID] [FIXED] - Unify onMomentumEnd callback behaviour in android with iOS

Test Plan:

Added updated RN tester examples to demonstrate the scroll behaviour when done programatically

Screen.Recording.2024-03-26.at.1.29.30.PM.mov
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 26, 2024
@Biki-das Biki-das changed the title Fix:-Unify onMomentumEnd callback behaviour in android with iOS Mar 26, 2024
@analysis-bot
Copy link

analysis-bot commented Mar 26, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,385,676 +411
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,760,578 +316
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 99d0c54
Branch: main
@Biki-das
Copy link
Contributor Author

Biki-das commented Mar 27, 2024 •
edited
Loading

/rebase
@Biki-das Biki-das force-pushed the fixes-scroll-action branch 2 times, most recently from 54d6460 to 2b914ff Compare March 28, 2024 09:36
@Biki-das
Copy link
Contributor Author

@hoxyq could you help shedding some light on this one!, someone who could review this potentially and give some feedback!
@hoxyq
Copy link
Contributor

hoxyq commented Apr 10, 2024

@hoxyq could you help shedding some light on this one!, someone who could review this potentially and give some feedback!

Thanks for flagging, usually we get notified when CI jobs are green on PR, so its ready for a review

Unfortunately this is out of my area of expertise for React Native, cc @NickGerleman @javache who might have opinion on this
@Biki-das
Copy link
Contributor Author

@hoxyq could you help shedding some light on this one!, someone who could review this potentially and give some feedback!

Thanks for flagging, usually we get notified when CI jobs are green on PR, so its ready for a review

Unfortunately this is out of my area of expertise for React Native, cc @NickGerleman @javache who might have opinion on this

wow! thats good to know! thanks for the reply!
@Biki-das
Copy link
Contributor Author

\rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
4 participants
@Biki-das @analysis-bot @hoxyq @facebook-github-bot