This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Riak #6
Merged
Riak #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * or if all properties have to be set, even if only a subset of properties | ||
| * changed. | ||
| * | ||
| * @return bool |
There was a problem hiding this comment.
you should use {@inheritDoc} for all methods documented in the interface, to avoid duplicating all phpdoc. It makes it easier to maintain it (typos occurs only in 1 place for instance)
|
I've made some changes according @stof suggestions. |
| @@ -3,6 +3,12 @@ | |||
| "require": { | |||
| "doctrine/common": "*" | |||
| }, | |||
| "suggest": { | |||
| "riak/riak-client": "dev-master" | |||
There was a problem hiding this comment.
suggest does not expect a version constraint but a string displayed to the user. so you could make it better by using "riak/riak-client": "to use the Riak storage". This will output "doctrine/key-value-store" suggest installing "riak/riak-client" (to use the Riak storage)
There was a problem hiding this comment.
Ah awesome!
Thank you ;)
|
@beberlei It's mergeable? |
beberlei
added a commit
that referenced
this pull request
Jul 3, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the riak storage.
It use the update from the offical php-driver.