fix: move from/to parsing to the very top #8389
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation, there's an option to use the syntax "from ... to ..." for dateRange, which uses the Chrono library under the hood. My intention is to get a relative dateRange for the entire week a week ago. The prompt I use is `from (14 days before this week) to (7 days before this week)`. If I put the prompt into Chrono standalone, it works perfectly and returns the dates I expect. However, Cube processes it differently — it only returns the date range for "last week" and ignores the rest of the prompt. I investigated the source code and realized this issue occurs because of the order of conditions in `dateParser.js`. If a prompt contains "this week", "this month", "this day", etc., only this part will be handled, and the rest will be ignored. My proposal in this PR is to move the "from / to" condition to the very top, ensuring that 'from / to' will also be handled if they contain "this week", "this month", "this day", etc.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
|
Thanks for your PR @tsaplev 🙌 While this change generally makes sense to me, I believe applying it will be a breaking change since other Cube users might already depend on the particular order of relative date rules resolution. So, we would need to do at least a minor release if we merge this changes. I'll let @paveltiunov to chime in here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, there's an option to use the syntax "from ... to ..." for dateRange, which uses the Chrono library under the hood.
My intention is to get a relative dateRange for the entire week a week ago. The prompt I use is
from (14 days before this week) to (7 days before this week). If I put the prompt into Chrono standalone, it works perfectly and returns the dates I expect. However, Cube processes it differently — it only returns the date range for "last week" and ignores the rest of the prompt.I investigated the source code and realised this issue occurs because of the order of conditions in dateParser.js. If a prompt contains "this week", "this month", "this day", etc., only this part will be handled, and the rest will be ignored. My proposal in this PR is to move the "from / to" condition to the very top, ensuring that 'from / to' will also be handled if they contain "this week", "this month", "this day", etc.