Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duckdb-driver): remove unnecessary installing and loading HttpFS extension #8375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benyaminsalimi
Copy link
Contributor

@benyaminsalimi benyaminsalimi commented Jun 18, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Refactor duck-db driver: there is no need to install and load httpfs

@benyaminsalimi benyaminsalimi requested a review from a team as a code owner June 18, 2024 19:51
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 7:52pm
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 18, 2024
@igorlukanin
Copy link
Member

Hi @benyaminsalimi 👋 Is it because httpfs will get autoloaded on first use? Was this behavior introduced in some recent version of DuckDB?

@benyaminsalimi
Copy link
Contributor Author

Indeed, but I don't know from which version but for current one.
You can see the details here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver:duckdb pr:community Contribution from Cube.js community members.
3 participants